[refactor] #132: refactor codegen for enum #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinI
force-pushed
the
iroha2-codegen
branch
2 times, most recently
from
148ea5e
to
d94f829
Compare
Signed-off-by: Artemii Gerasimovich <gerasimovich@soramitsu.co.jp>
QuentinI
force-pushed
the
iroha2-codegen
branch
from
d94f829
to
9adfb7d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally no more metaclass voodoo in codegen, also (probably) more pythonic types for rust enums.
Next steps would be to refactor codegen on the rust side, then probably move as much of codegen as possible from python to rust for better IDE/typechecking experience for end-users.
Closes #132, also at least partially addresses #134